Skip to content

fix(chat): Adding conditional check for Read and List tool execution #7026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 15, 2025
Merged

fix(chat): Adding conditional check for Read and List tool execution #7026

merged 4 commits into from
Apr 15, 2025

Conversation

@laileni-aws
Copy link
Contributor

@laileni-aws laileni-aws commented Apr 11, 2025

Problem

  • Reading Tool and List Directory tool requires users acceptance if IDE wants to perform operation outside of workspace.

Solution

  • This problem is fixed as part of this PR
    image
  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions
Copy link

github-actions bot commented Apr 11, 2025

  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

@laileni-aws laileni-aws force-pushed the feature/agentic-chat branch from d381150 to 77761e9 Compare April 11, 2025 22:56
@laileni-aws laileni-aws marked this pull request as ready for review April 11, 2025 22:56
@laileni-aws laileni-aws requested review from a team as code owners April 11, 2025 22:56
jguoamz
jguoamz reviewed Apr 11, 2025
View reviewed changes
ctlai95
ctlai95 reviewed Apr 11, 2025
View reviewed changes
@laileni-aws laileni-aws force-pushed the feature/agentic-chat branch from 77761e9 to 6a9ccfa Compare April 11, 2025 23:07
jguoamz
jguoamz suggested changes Apr 11, 2025
View reviewed changes
Copy link
Contributor

@jguoamz jguoamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test failed

@laileni-aws laileni-aws reopened this Apr 11, 2025
@laileni-aws laileni-aws force-pushed the feature/agentic-chat branch from 5ffb846 to c17a7fd Compare April 11, 2025 23:38
@laileni-aws laileni-aws requested a review from jguoamz April 11, 2025 23:39
@laileni-aws laileni-aws force-pushed the feature/agentic-chat branch from d8eb5d8 to 62bb166 Compare April 14, 2025 21:47
zixlin7
zixlin7 reviewed Apr 14, 2025
View reviewed changes
@laileni-aws
Copy link
Contributor Author

laileni-aws commented Apr 15, 2025

/retryBuilds

@zixlin7 zixlin7 merged commit 741c2c4 into aws:feature/agentic-chat Apr 15, 2025
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ctlai95 ctlai95 Awaiting requested review from ctlai95

@ashishrp-aws ashishrp-aws Awaiting requested review from ashishrp-aws

2 more reviewers

@zixlin7 zixlin7 zixlin7 approved these changes

@jguoamz jguoamz jguoamz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@laileni-aws @ctlai95 @zixlin7 @jguoamz @ashishrp-aws